Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative: Prevent superfluous warnings from ranlib about libcellml.a having no symbols on macOS #536

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

hsorby
Copy link
Contributor

@hsorby hsorby commented Jan 29, 2020

Addresses #532.

Rather than playing around with compiler flags it may be better to exclude the debug files from the build unless explicitly enabled. These functions are not used except when debugging.

Copy link
Contributor

@agarny agarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well for me.

@agarny agarny merged commit c2596df into cellml:develop Jan 30, 2020
@hsorby hsorby deleted the no_symbols_i532 branch January 30, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants